Skip to content

gh-150232: Change Thread group parameter doc from 'should be' to 'must be'#150238

Closed
My-ABC wants to merge 2347 commits into
python:mainfrom
My-ABC:test3145
Closed

gh-150232: Change Thread group parameter doc from 'should be' to 'must be'#150238
My-ABC wants to merge 2347 commits into
python:mainfrom
My-ABC:test3145

Conversation

@My-ABC
Copy link
Copy Markdown

@My-ABC My-ABC commented May 22, 2026

This PR updates the documentation for threading.Thread to accurately reflect the implementation.

The implementation uses assert group is None, which makes the parameter mandatory. The documentation is updated from "should be None" to "must be None".

Fixes #150232

serhiy-storchaka and others added 30 commits March 22, 2026 09:25
…LLs (pythonGH-146129) (pythonGH-146155)

(cherry picked from commit 0f2246b)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
… in socket module (pythonGH-146248) (pythonGH-146274)

(cherry picked from commit c30fae4)

Co-authored-by: AN Long <aisk@users.noreply.github.com>
…pythonGH-145248) (pythonGH-146288)

(cherry picked from commit 97c725c)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
…ythonGH-145145) (pythonGH-146290)

(cherry picked from commit 161329c)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
… (pythonGH-146328)

pythongh-108907: ctypes: Document _type_ codes (pythonGH-145837)

Add `_SimpleCData._type_` docs.

Add type codes to the summary table.

Cross-link `struct`, `array`, and `ctypes`; throw in `numpy` too.
(Anyone wanting to add a code should be aware of those.)

Add `py_object`, and `VARIANT_BOOL` for completeness.
(cherry picked from commit 1114d7f)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
…ython#146332) (python#146336)

pythongh-146197: Run -m test.pythoninfo on the Emscripten CI (python#146332)


(cherry picked from commit a57209e)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
…ythonGH-139176) (pythonGH-144802)

To avoid duplicate content in the Enum HOWTO and
API documentation which is not automatically synced,
the section about supported __dunder__ and _sunder
names is moved from HOWTO to API docs.

See also python#136791
(cherry picked from commit 629a363)

Co-authored-by: Rafael Weingartner-Ortner <38643099+RafaelWO@users.noreply.github.com>
…l exception sequence is mutated (pythonGH-141736) (pythonGH-144445)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
…tps (pythonGH-145304) (pythonGH-145322)

(cherry picked from commit 11eec7a)

Co-authored-by: indoor47 <indoor47@gmail.com>
Co-authored-by: Adam (indoor47) <adamai@agentmail.to>
…pythonGH-146126)

(cherry picked from commit 2c6afb9)

Co-authored-by: Bartosz Grabowski <58475557+bartosz-grabowski@users.noreply.github.com>
…nGH-146331)

(cherry picked from commit c94048b)

Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
…honGH-146214)

(cherry picked from commit 82a24a4)

Co-authored-by: Seth Michael Larson <seth@python.org>
…rst padded quad (pythonGH-145267) (pythonGH-146326)

Base64 decoder (see binascii.a2b_base64(), base64.b64decode(), etc)
no longer ignores excess data after the first padded quad in non-strict
(default) mode.  Instead, in conformance with RFC 4648, it ignores the
pad character, "=", if it is present before the end of the encoded data.
(cherry picked from commit 4561f64)
…le.h (pythonGH-131832) (pythonGH-146340)

(cherry picked from commit 59e2330)

Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>
…ythonGH-131821) (pythonGH-146339)

(cherry picked from commit cc8e6d2)

Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>
…ythonGH-144805) (pythonGH-145397)

(cherry picked from commit c9b96b1)

Co-authored-by: Łukasz Langa <lukasz@langa.pl>
…s docstring (pythonGH-145889) (pythonGH-146036)

The get_annotations() docstring incorrectly referred to the SOURCE
format, which was renamed to STRING during PEP 749 development.
(cherry picked from commit 2a0fa50)

Co-authored-by: wavebyrd <160968744+wavebyrd@users.noreply.github.com>
Co-authored-by: Carson Jones <carson@Carsons-MacBook-Pro.local>
…46347) (python#146349)

pythongh-146202: Create tmp_dir in regrtest worker (pythonGH-146347)

Create tmp_dir in libregrtest.worker since the directory can be
different than the --tempdir directory.
(cherry picked from commit bcff99c)

Co-authored-by: Victor Stinner <vstinner@python.org>
… for python 3.13 (pythonGH-140243) (pythonGH-146351)

(cherry picked from commit fae5761)

Co-authored-by: Parman Mohammadalizadeh <prmma23@gmail.com>
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
…ed strings (pythongh-146072) (python#146390)

Fix free-threading scaling bottleneck in sys.intern and `PyObject_SetAttr` by
avoiding the interpreter-wide lock when the string is already interned and
immortalized.

(cherry picked from commit 6009309)
…ythonGH-146384)

(cherry picked from commit 119fce7)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
…lly (pythonGH-146375) (python#146411)

Dynamically allocates the port for the pyrepl browser test, so that multiple
tests can run at the same time. Also allows the pyrepl test to honor the
CROSS_BUILD_DIR environment variable.
(cherry picked from commit 2be147e)
pythonGH-145099) (python#146412)

Co-authored-by: clintonsteiner <47841949+clintonsteiner@users.noreply.github.com>
…pythonGH-146374) (python#146418)

pythongh-146358: Fix warnings.catch_warnings on Free Threading (pythonGH-146374)

catch_warnings now also overrides warnings.showwarning() on Free
Threading to support custom warnings.showwarning().
(cherry picked from commit 0055140)

Co-authored-by: Victor Stinner <vstinner@python.org>
…GH-146425) (pythonGH-146430)

Fix typo in 3.14 What's New tail call interpreter docs (pythonGH-146425)
(cherry picked from commit 4447f23)

Co-authored-by: johnthagen <johnthagen@users.noreply.github.com>
…honGH-146402) (python#146438)

pythongh-138573: Filter out failing math tests on Solaris (pythonGH-146402)
(cherry picked from commit 8e1469c)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
… (python#146460)

pythongh-145633: Fix struct.pack('f') on s390x (pythonGH-146422)

Use PyFloat_Pack4() to raise OverflowError.
Add more tests on packing/unpacking floats.
(cherry picked from commit 8de70b3)

Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
…thonGH-146319) (python#146468)

pythongh-146318: Document that signal.SIGSTOP is Unix-only (pythonGH-146319)
(cherry picked from commit e44993a)

Co-authored-by: Jonathan Dung <jonathandung@yahoo.com>
…et() (pythonGH-146173) (python#146473)

pythongh-146059: Call fast_save_leave() in pickle save_frozenset() (pythonGH-146173)

Add more pickle tests: test also nested structures.
(cherry picked from commit 5c0dcb3)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 22, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 22, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented May 22, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@serhiy-storchaka
Copy link
Copy Markdown
Member

Please update the main branch in your repository, rebase your branch on main and create a new PR. Check that the diff only contains expected changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

threading.Thread: documentation says group "should be None", but implementation enforces it with AssertionError